Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-3360 ServerLRAFilter is relying on the wrong RESTEasy behavior #1674

Merged
merged 1 commit into from Sep 24, 2020

Conversation

xstefank
Copy link
Collaborator

https://issues.redhat.com/browse/JBTM-3360

!MAIN !TOMCAT !AS_TESTS !RTS !JACOCO !XTS !QA_JTA !QA_JTS_JACORB !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !BLACKTIE !PERF LRA NO_WIN !DB_TESTS !mysql !db2 !postgres !oracle

Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch.

Note that CI is disabled at the moment while we do some perf testing. Let's wait until this PR has benefited from CI testing before merging.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@xstefank
Copy link
Collaborator Author

TckRecoveryTests.testCancelWhenParticipantIsUnavailable is unstable in the CI, should we create a new JBTM to investigate this?

@ochaloup
Copy link
Contributor

@xstefank yes, agree, please do so. The failure is not connected with your PR and it could be we are back with the failure https://issues.redhat.com/browse/JBTM-3318.
In fact it could be just a timeout issue as the CI is currently fully occupied and the timeout could elapse for this LRA test.

I tried this locally as well and the test passes. I'm going to merge this and we need to investigate about the failure then.

@ochaloup ochaloup merged commit c46bcc0 into jbosstm:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants