Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Excel CDF file detection #20

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Conversation

FernandoDoming
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Jul 13, 2017

Coverage Status

Coverage increased (+0.05%) to 92.871% when pulling 7c9cc4c on FernandoDoming:excel_ole into 6009ffa on jbremer:master.

@jbremer
Copy link
Member

jbremer commented Jul 13, 2017

Sweet, can you merge this functionality into the office_ole function though, so ole.listdir() is only invoked once?

@codecov-io
Copy link

codecov-io commented Jul 13, 2017

Codecov Report

Merging #20 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
+ Coverage   93.29%   93.3%   +0.01%     
=========================================
  Files          23      23              
  Lines        1044    1046       +2     
=========================================
+ Hits          974     976       +2     
  Misses         70      70
Impacted Files Coverage Δ
sflock/ident.py 88.57% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6009ffa...cccc64d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 92.543% when pulling cccc64d on FernandoDoming:excel_ole into 6009ffa on jbremer:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.83% when pulling cccc64d on FernandoDoming:excel_ole into 6009ffa on jbremer:master.

@jbremer
Copy link
Member

jbremer commented Jul 13, 2017

All tests passed, excellent. Thanks!

@jbremer jbremer merged commit 861c7ef into hatching:master Jul 13, 2017
psrok1 pushed a commit to CERT-Polska/sflock that referenced this pull request Apr 6, 2023
Revert "fix eml parsing and change the package determination"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants