Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on windows with lots of EOL violations #43

Merged
merged 2 commits into from
Jun 12, 2015

Conversation

simonjenga
Copy link
Contributor

#42 Build failed on windows with lots of EOL violations

@dmarkov
Copy link

dmarkov commented Jun 11, 2015

@simonjenga Thanks, someone will review your pull request soon

@dmarkov
Copy link

dmarkov commented Jun 11, 2015

@yegor256 review this pls (it's a rather short pull request)

@yegor256
Copy link
Member

@rultor merge it pls

@rultor
Copy link
Contributor

rultor commented Jun 12, 2015

@rultor merge it pls

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 186c1d9 into jcabi:master Jun 12, 2015
@rultor
Copy link
Contributor

rultor commented Jun 12, 2015

@rultor merge it pls

@yegor256 Done! FYI, the full log is here (took me 7min)

@dmarkov
Copy link

dmarkov commented Jun 15, 2015

@yegor256 16 mins sent to your balance (ID 000-67e8542c), many thanks! It took 21 hours and 47 mins.... review comments (c=1) added as a bonus... +16 added to your rating, at the moment it is: +6172

@dmarkov
Copy link

dmarkov commented Jun 15, 2015

@rultor deploy now pls

@rultor
Copy link
Contributor

rultor commented Jun 15, 2015

@rultor deploy now pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Jun 15, 2015

@rultor deploy now pls

@dmarkov Done! FYI, the full log is here (took me 6min)

@yegor256
Copy link
Member

@simonjenga build is passing now on appveyor

@simonjenga simonjenga deleted the 42 branch July 4, 2015 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants