what Contents#iterate() is doing?

[yegor256]

I don't understand what Contents#iterate() is doing? This functionality is not provided by Github and we don't have an integration test for the method. I think it's obsolete and should be deleted.

[yegor256]

I think this method was originally intended to list content of a directory. For example, see https://api.github.com/repos/jcabi/jcabi-github/contents/src This request returns a list of files in a directory, and should be treated differently (since it's not a JSON object, but an array).

In that case, it makes sense. Let's leave the method in the interface, but document it properly and make sure it works. Now it doesn't work.

[dmarkov]

I'll find a developer for the task soon...

[dmarkov]

thank you for the ticket reported, I topped your account for 15 mins, transaction 000-70b57f21

[dmarkov]

@aistomin this is your task now, please help

[dmarkov]

@aistomin just a reminder that you're working with this task for 12 days already

[dmarkov]

@aistomin this task is taking too long, I have to change the performer, sorry. Please stop working with it right now. See our no obligations principle

[dmarkov]

@svarovski this task is for you, keep these principles in mind, and don't hesitate to ask any technical questions

[dmarkov]

@svarovski 30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

[dmarkov]

@svarovski you're working with this ticket for the last 11 days. If it's not closed within the next 48 hours, it will be re-assigned to someone else, see No Obligations principle

[dmarkov]

@svarovski it takes too long. Usually, we expect any task to be finished in less than a week. I'll assign someone else. Please stop working with it right now. See our no obligations principle

[dmarkov]

@lthuangiang this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here

[dmarkov]

@lthuangiang The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

[lthuangiang]

@yegor256 I have a concern on this task. Base on API, https://developer.github.com/v3/repos/contents/#response-if-content-is-a-directory, response can be list of files in directory, or list of directories, or both directories and files.

Here is example
GET https://api.github.com/repositories/14204295/contents/src/main/java/com/jcabi/github

[
  {
    "name": "mock",
    "path": "src/main/java/com/jcabi/github/mock",      <----- a directory
    ....
  },
  {
    "name": "package-info.java",
    "path": "src/main/java/com/jcabi/github/package-info.java",   <----- it's a file
    .....
  },
  {
    "name": "wire",
    "path": "src/main/java/com/jcabi/github/wire",     <------ it's a directory
    ----
]

So should we only return contents if they is file types? or we will loop all sub directories to find contents?

[yegor256]

We shouldn't loop into directories, but just return a list of files/directories returned. Or I didn't understand your question

[lthuangiang]

as far as my understand, Content object is representation for File in Github, if we return list of files/directories, we will get error when trying to access directory. like #903 . I created this issue to get your advise.

[longtimeago]

@yegor256 @lthuangiang Looks like the issue is closely related to this one #903. Any news here?

[dmarkov]

@lthuangiang the task is overdue, and I have to re-assign it to someone else. Please, stop working with it immediately. In general, we're against overdue tasks, check this page

[dmarkov]

@darkled this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here

30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

[dmarkov]

@darkled you're holding this task for 12 days already... -30 added to your rating, current score is: +60

[asaen]

@dmarkov this issue as mentioned is closely related to #903. From my point of view, nothing can be done here before that issue is closed. And I am not sure what is this score rating about?

[asaen]

@dmarkov please, assign this task to someone else

[dmarkov]

@dmarkov please, assign this task to someone else

@darkled I will assign somebody else to this issue

[dmarkov]

@darkled you've been working with this task for too long. I'm sorry, but I'll assign someone else. Please stop working with it. See our no obligations principle; -60 added to your rating, current score is: -90

[asaen]

@dmarkov @yegor256 I am not sure these -60 are correct, since I've rejected the task 3 days ago, aren't they?

[dmarkov]

@maurezen it's your task, go ahead

[maurezen]

@dmarkov @yegor256 shouldn't there also be my account label on this ticket?

[maurezen]

@yegor256 @dmarkov this depends on #968 and probably on #903 as well (are not these two bugs the same problem?) . What do we do with that? Is puzzle submission sufficient in this case?

Also are we talking about RtContents here? Contents is an interface.

[maurezen]

@yegor256 any comments?

[yegor256]

@maurezen I think we should create an integration test for RtContents and take it from there. If it passes, good, close the ticket. If it doesn't pass, try to fix it. If you can't, create a puzzle and close the ticket.

[maurezen]

@yegor256 created a pull request here #995

[maurezen]

@yegor256 pull request #995 merged to master, please close the issue.

[yegor256]

@maurezen thanks!

[maurezen]

@yegor256 thanks!

@dmarkov the issue is closed.

[dmarkov]

once 863-4e783bd3 puzzle is resolved (later, in another ticket), this ticket will be fully complete

[maurezen]

@yegor256 @dmarkov I'm confused as to what's the policy in this case. I believe in jcabi/jcabi-manifests#16 the ticket was considered complete once closed, despite the puzzle introduced. What way should it be?

[yegor256]

@maurezen this task is done, the puzzle will be fixed in another task, later

[dmarkov]

@maurezen 30 mins sent to your balance (ID 50904270), many thanks!. +30 added to your rating, at the moment it is: +915

[0pdd]

@yegor256 the puzzle #unknown is still not solved.