Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonResponse should be able to read non-Unicode JSON #1

Closed
yegor256 opened this issue Feb 23, 2014 · 6 comments
Closed

JsonResponse should be able to read non-Unicode JSON #1

yegor256 opened this issue Feb 23, 2014 · 6 comments

Comments

@yegor256
Copy link
Member

JsonResponse is now relying on a proper Unicode formatting of JSON documents (see line 95). When JSON contains non-Unicode characters, the class throws a runtime exception. For example, try this document (which is a valid JSON according to RFC 4627):

{"test": "\u0000"}
@dmarkov
Copy link

dmarkov commented Mar 3, 2014

@carlosmiranda this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here

@dmarkov
Copy link

dmarkov commented Mar 3, 2014

@carlosmiranda The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

carlosmiranda added a commit to carlosmiranda/jcabi-http that referenced this issue Mar 4, 2014
@carlosmiranda
Copy link
Contributor

Code is now ready for review, pull request is at #2.

carlosmiranda added a commit to carlosmiranda/jcabi-http that referenced this issue Mar 4, 2014
ghost pushed a commit that referenced this issue Mar 4, 2014
#2: pull request Issue #1 JsonResponse can now properly parse control characters
@carlosmiranda
Copy link
Contributor

@yegor256 Are you satisfied with the solution here? If so please close the issue, or let me know if there's more to be done.

@yegor256
Copy link
Member Author

yegor256 commented Mar 4, 2014

sure, thanks!

@yegor256 yegor256 closed this as completed Mar 4, 2014
@dmarkov
Copy link

dmarkov commented Mar 4, 2014

@carlosmiranda Much obliged! I've added 30 mins to your account in payment "36777808"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants