-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1 JsonResponse can now properly parse control characters #2
Conversation
* @see <a href="http://tools.ietf.org/html/rfc4627">RFC 4627</a> | ||
*/ | ||
private String escapeControl(final String input) { | ||
final Pattern pattern = Pattern.compile("[\u0000-\u001f]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be a static private field, for the sake of performance
@carlosmiranda one minor comment, see above |
@yegor256 Your comment has been addressed, kindly have another look. :) |
good to merge |
Hey, let me try to merge your branch |
I've merged your branch
|
@yegor256 please review this pull request, taking into account these rules |
@yegor256 There is 15 mins budget allocated for the review |
@yegor256 I just added 18 mins to your account, many thanks for your contribution.. |
As per RFC 4627 control characters
U+0000
toU+001F
should be escaped. I created a custom function that does exactly that and used it before invokingcreateReader
.