Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private key file with pass phrase #30

Closed
wants to merge 1 commit into from
Closed

Add support for private key file with pass phrase #30

wants to merge 1 commit into from

Conversation

guzzard
Copy link

@guzzard guzzard commented Jul 21, 2015

Add support for private key file with pass phrase. Key file and pass phrase are passed as byte[] in order to use the existing appropriate Jsch constructor.


Add support for private key file with pass phrase. Key file and pass phrase are passed as byte[] in order to use the existing appropriate Jsch constructor.
@guzzard guzzard mentioned this pull request Jul 21, 2015
@dmarkov
Copy link

dmarkov commented Jul 21, 2015

@guzzard Thanks, I will ask someone to do a code review here, thanks for your pull request

@dmarkov
Copy link

dmarkov commented Jul 21, 2015

@ggajos please review this one

* @throws UnknownHostException If fails
* @checkstyle ParameterNumberCheck (6 lines)
*/
public SSH(final String adr, final int prt, final String user,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guzzard this constructor is too big, think we should create some object that will handle preparation of those objects, also validation.

@ggajos
Copy link

ggajos commented Jul 21, 2015

@guzzard some checks failed

@ggajos
Copy link

ggajos commented Jul 21, 2015

@guzzard I can't see any test cases here also

@ggajos
Copy link

ggajos commented Jul 21, 2015

@guzzard few comments above

@ggajos
Copy link

ggajos commented Aug 19, 2015

@guzzard @yegor256 can we close this?

@ggajos
Copy link

ggajos commented Sep 15, 2015

@guzzard @yegor256 I think is no longer relevant and we should close it

@yegor256
Copy link
Member

@ggajos ok, I'm closing

@yegor256 yegor256 closed this Sep 17, 2015
@dmarkov
Copy link

dmarkov commented Sep 18, 2015

@ggajos Many thanks! 20 mins were added to your account in Transaction ID AP-1BP58002BH570513Y (task took 1389 hours and 46 mins). review comments (c=5) added as a bonus. +20 to your rating, your total score is +100

@salemrartin
Copy link

Hello, has this pull request been declined? I am not sure I understand @ggajos comment "I think is no longer relevant and we should close it"

I am stuck in my project and I really need this feature

Thanks

@dmarkov
Copy link

dmarkov commented Mar 30, 2016

@guzzard once 30-15484dec/#50 puzzle is resolved (later, in another ticket), this ticket will be fully complete

@guzzard guzzard deleted the patch-1 branch January 3, 2018 19:48
@0pdd
Copy link

0pdd commented Jul 4, 2022

@guzzard the puzzle #unknown is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants