-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for private key file with pass phrase #30
Conversation
Add support for private key file with pass phrase. Key file and pass phrase are passed as byte[] in order to use the existing appropriate Jsch constructor.
@guzzard Thanks, I will ask someone to do a code review here, thanks for your pull request |
@ggajos please review this one |
* @throws UnknownHostException If fails | ||
* @checkstyle ParameterNumberCheck (6 lines) | ||
*/ | ||
public SSH(final String adr, final int prt, final String user, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guzzard this constructor is too big, think we should create some object that will handle preparation of those objects, also validation.
@guzzard some checks failed |
@guzzard I can't see any test cases here also |
@guzzard few comments above |
@ggajos ok, I'm closing |
Hello, has this pull request been declined? I am not sure I understand @ggajos comment "I think is no longer relevant and we should close it" I am stuck in my project and I really need this feature Thanks |
Add support for private key file with pass phrase. Key file and pass phrase are passed as byte[] in order to use the existing appropriate Jsch constructor.