Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS validation by URL is not implemented or just does not work #7

Closed
emukhin opened this issue Jan 20, 2015 · 21 comments
Closed

CSS validation by URL is not implemented or just does not work #7

emukhin opened this issue Jan 20, 2015 · 21 comments
Labels

Comments

@emukhin
Copy link

emukhin commented Jan 20, 2015

ValidationResponse responseCSS = new ValidatorBuilder().css().validate("http://google.com");
returns "Parse Error"

@yegor256
Copy link
Member

@emukhin did you try http://www.google.com instead?

@emukhin
Copy link
Author

emukhin commented Jan 20, 2015

@yegor256 I did. Still the same.
here is what I got as the response:

Validity: FALSE
Validator: "http://jigsaw.w3.org/css-validator/"
DOCTYPE: ""
Charset: "UTF-8"
Errors:
[1:0] "", "", "", "Parse Error"
Warnings:

@yegor256
Copy link
Member

@emukhin maybe the W3C validator is broken at the moment. sometimes this happens. please try again in a few hours.

@emukhin
Copy link
Author

emukhin commented Jan 21, 2015

@yegor256 I've been trying since yesterday. No luck. Are you sure it supposed to work that way?

@emukhin
Copy link
Author

emukhin commented Jan 21, 2015

Simple get request http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.google.com%2F&output=soap12 returns well-formed results that makes me think that the service is working

@yegor256
Copy link
Member

@emukhin this could be our bug then. let us investigate...

@yegor256 yegor256 added the bug label Jan 21, 2015
@dmarkov
Copy link

dmarkov commented Jan 21, 2015

@apocarteres the issue is yours, please help

@apocarteres
Copy link

yeah, it's bug. Btw, http://www.google.com is not valid anyway
screen shot 2015-01-21 at 2 46 21 pm

@apocarteres
Copy link

Well, according to source code ValidatorBuilder().css().validate expects the CSS, but not the URL, thus Parse error is expected here, since it can't parse http://google.com as CSS document

@yegor256
Copy link
Member

@apocarteres let's update the documentation to avoid such confusions?

@apocarteres
Copy link

@yegor256 ok

@emukhin
Copy link
Author

emukhin commented Jan 21, 2015

So, validation by URL won't be implemented, right?

@apocarteres
Copy link

@emukhin probably in future, but right now it consumes CSS only

@apocarteres
Copy link

@yegor256 seems that all corresponding JavaDocs say that HTML/CSS is expected. I haven't managed to find JavaDocs which says that URL expected there.

@yegor256
Copy link
Member

@apocarteres let's emphasize this in the documentation, with a "notice" or something. To make sure it's clear that we're expecting a text, not a URL

apocarteres pushed a commit to apocarteres/jcabi-w3c that referenced this issue Jan 21, 2015
apocarteres pushed a commit to apocarteres/jcabi-w3c that referenced this issue Jan 22, 2015
@apocarteres
Copy link

@yegor256 please check

@yegor256
Copy link
Member

@apocarteres I'm not the reporter, ask @emukhin to review it

@apocarteres
Copy link

@emukhin added comment to JavaDoc. please check

@emukhin
Copy link
Author

emukhin commented Jan 25, 2015

Thanks. It seems clear. Feel really sorry for bothering. I should have believed the documentation. But I thought that you might forgot to mention this way of using the library.

@apocarteres
Copy link

@emukhin nps. can u close the issue please?

@emukhin emukhin closed this as completed Jan 26, 2015
@dmarkov
Copy link

dmarkov commented Jan 27, 2015

@apocarteres done, I added 30 mins in payment 50842099. +30 to your rating, your total score is +45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants