Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reasonable rate limit defaults in Nginx config #13

Open
jcalazan opened this issue Jan 25, 2015 · 1 comment
Open

Add reasonable rate limit defaults in Nginx config #13

jcalazan opened this issue Jan 25, 2015 · 1 comment

Comments

@jcalazan
Copy link
Owner

http://nginx.org/en/docs/http/ngx_http_limit_req_module.html

Should probably add a var to check as well before including it in the config: enable_nginx_limit_req

@YPCrumble
Copy link
Collaborator

@jcalazan I've been deploying a site and making some updates to my nginx config so thought to look at this issue as well. These are the best tutorials I've found:

The issue is that it appears the limits need to be applied to specific locations (i.e., in the Lincoln Loop tutorial they apply it to the login page). This would be specific to every site, so I suppose we'd need to let the user supply a list of url endpoints they'd like to rate-limit.

This would mean a pretty extensive set of configuration options:

  • requests/time period setting

  • List of rate-limiting "zones" and their associated locations
  • Types of requests to rate-limit (i.e., do we limit only POST or GET and POST? This is somewhat covered in the second tutorial which only limits POST requests. Not sure what the best implementation is here, or whether we should just make the limit apply to all requests by default.)

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants