Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ip/port hardcoded values #51

Open
jcarreira opened this issue Jun 14, 2017 · 3 comments
Open

Fix ip/port hardcoded values #51

jcarreira opened this issue Jun 14, 2017 · 3 comments
Assignees
Labels

Comments

@jcarreira
Copy link
Owner

We should think of getting rid of the IP/port hardcoded values scattered throughout the tests.

A benefit of the hard coded values is that they simplify testing because we only need to call the binary to run the test -- no need to create a custom launch script.

We will need to create a python script to launch these tests.

The IP/port values can come from a few places:

  1. ./configure --test_IP=127.0.0.1 --port=18723
  2. make IP=127.0.0.1 PORT=127.0.0.1 test

@TylerADavis What do you think?

@atumanov
Copy link
Collaborator

For all components of the system that need this port/ip information, I'd start them with a set of command line args (or a config file), which I'd use to specify this information at runtime (or, rather, start time). I would not do it at compile time.

@jcarreira
Copy link
Owner Author

Yes, agree.

I think we could provide something like

make CONFIG=path_to_config test

to execute a test script that can parse the test config and launch all the tests with the right arguments.

@TylerADavis
Copy link
Collaborator

@jcarreira Should we go ahead and close this? or leave it open as only the hardcoded IP values were fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants