Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define JCV_SQRT sqrt when using double #51

Closed
yoavmil opened this issue May 27, 2020 · 1 comment
Closed

#define JCV_SQRT sqrt when using double #51

yoavmil opened this issue May 27, 2020 · 1 comment

Comments

@yoavmil
Copy link

yoavmil commented May 27, 2020

First of, I used you library and it works great out of the box!

When using double, and not doing #define JCV_SQRT sqrt, gives warnings. you just missed it in the readme.md.

also a couple of feature requests, I could do some if you want:

  • let the user define JCV_REAL_TYPE double/float, and hide all other macros under the hood.
  • have a c++ wrapper, replacing the array pointer with std::vector etc.
  • support segments in addition to points - this is a big request.
@JCash
Copy link
Owner

JCash commented May 28, 2020

Thanks for using it!

I'll add JCV_SQRT to the docs!

  1. Sounds like a good suggestion

  2. Not sure why a C++ wrapper is needed, I think it will only obfuscate the data.
    Not to mention slow things down, and add code size and complexity.

  3. Yes, I've thought about that, but I'm afraid it's such a big task, that I'm most likely never going to have time to add that.

@yoavmil yoavmil closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants