Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify installation for Growl #6

Closed
Riduidel opened this issue May 20, 2014 · 3 comments
Closed

Clarify installation for Growl #6

Riduidel opened this issue May 20, 2014 · 3 comments

Comments

@Riduidel
Copy link

I've growl installed on my machine, but maven doesn't send any notification.

To undestand why, I've added a test to maven-notifier which creates and send a message.

That test outputs the following messages

11:30:56.251 [New I/O client worker #1-1] 67 DEBUG jgntp.message - Message received
GNTP/1.0 -ERROR NONE
Error-Code: 400
Error-Description: Invalid key hash
Origin-Machine-Name: NDX-PC-W7
Origin-Software-Name: Growl/Win
Origin-Software-Version: 2.0.9.1
Origin-Platform-Name: Microsoft Windows NT 6.1.7601 Service Pack 1
Origin-Platform-Version: 6.1.7601.65536
X-Message-Daemon: Growl/Win
X-Timestamp: 20/05/2014 11:30:56
11:30:56.261 [New I/O client worker #1-1] 40 ERROR c.g.j.m.n.growl.Slf4jGntpListener - Registration error: NOT_AUTHORIZED - Invalid key hash
11:30:56.261 [New I/O client worker #1-1] 158 INFO  c.g.c.j.internal.io.NioTcpGntpClient - Scheduling registration retry in [3-SECONDS]
11:30:59.271 [pool-2-thread-1] 68 DEBUG c.g.c.j.internal.io.NioGntpClient - Registering GNTP application [Maven]
11:30:59.271 [New I/O client worker #1-2] 51 DEBUG jgntp.message - Sending message
GNTP/1.0 REGISTER NONE SHA512:111581B770A50B07372A85ED928A8B6F3C34180782D43E1335BC3737E4FC57E70D23EBEFEFB3BF2363619E80D36707EF121AB8D9DA8C6E638F1927633B0428E6.9F99086EC1E3AD095E60EA607E321303
Application-Name: Maven
Notifications-Count: 1

Notification-Name: build-status-notification
Notification-Display-Name: Build result status
Notification-Enabled: True

Yup, I'm using Growl for Windows.

So, realizing it was mainly my fault, I guess it could be a good idea to have a standalone test mode of that notifier that would simply send a "maven-notifier is working" message to Growl and, if failing, try to examine error message to help the dumb user (me, in that case) configure this notifier. How ? well, I don't really know :-/

@jcgay
Copy link
Owner

jcgay commented May 24, 2014

I was using Growl for Windows too when I start writing maven-notifier :)

I have just added a new JGNTP listener to log errors with Maven when notification system fails (I don't remember why I have wrote one using SLF4J by the time, but it was stupid...).

So now when I misconfigure Growl I get:

> mvn test
[ERROR] Growl Registration error: NOT_AUTHORIZED - Missing key hash
[INFO] Scanning for projects...

I think you could have find your configuration problem faster with this error ?

Maybe I will add wiki pages with detailed screenshots of Growl and Snarl configuration to receive notifications, it may help.

Writing a tool to test notifier configuration should be doable, trying to automatically explain the error log can be trickier, I'll keep that in mind !

Thanks for the report.

@Riduidel
Copy link
Author

The logger would be a great way to obtain easily configuration errors.
In fact, using maven-like way, you could redirect user to a wiki page when an error is displayed. This way, we could populate that wiki lazily ...

@jcgay
Copy link
Owner

jcgay commented May 27, 2014

yeah great idea ! I'll add wiki URLs in the error messages logged.

Thanks

@jcgay jcgay closed this as completed in 77ba721 May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants