Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary file creation #10

Closed
pun-ky opened this issue Jul 30, 2018 · 12 comments
Closed

Temporary file creation #10

pun-ky opened this issue Jul 30, 2018 · 12 comments

Comments

@pun-ky
Copy link

pun-ky commented Jul 30, 2018

When I have integrated this notifier into Gradle plugin, there is being created a file named "null" (on CWD) with contents "Active code page: 1250". This is annoying for my plugin users, because this file is created under directory using VCS.

Now I am forced to remove that file manually, even just after Notifier.close() (it is not cleaning :/)

Environment: Windows 10, 64-bit
Send-notification: 0.14.0
Java: 8

@pun-ky
Copy link
Author

pun-ky commented Jul 30, 2018

one extra question, I specified an application name but still seeing on Windows "Java Platform" in the bottom of notification. I have no idea how to override it. Is it even possible? I was thinking that Application is for that case exactly...

@jcgay
Copy link
Owner

jcgay commented Aug 10, 2018

Huum I have no idea what's this file is :(
Which notifier are you using ?

@pun-ky
Copy link
Author

pun-ky commented Aug 10, 2018

Default for Windows 10. I don't know exactly which one is it. Looks like native

@jcgay
Copy link
Owner

jcgay commented Sep 2, 2018

I have just tried to reproduce it (with this VM), but I don't (I'm not using Windows myself 😓)...

I have launched send-notification with its CLI, or with Maven (via maven-notifier) without luck. I don't find a null file created in the current directory.

Maybe I do something wrong ?

Is this this kind of notification you see ?
notification

I have noticed the Java Platform thingy too (might have appeared with Windows 10), not sure if I can remove it, I'll have a look.

@withparadox2
Copy link

I use apply plugin: 'fr.jcgay.gradle-notifier', get a null file every time after I sync android project.

Environment: Windows 7, 64-bit
gradle-notifier 1.2.0
Java: 8

@jcgay
Copy link
Owner

jcgay commented Oct 25, 2018

Ok thanks.
I'll give it another try with gradle 😕

@jcgay
Copy link
Owner

jcgay commented Oct 28, 2018

I think I have been able to reproduce it.

It seems to appear when trying to find BurntToast.
I have a null file created with content:

Active code page: 1252

To prevent it at the moment, you can choose a working notifier by configuration instead of letting send-notification choose one for you.

For gradle it would be:

notifier {
    implementation = 'systemtray'
}

@withparadox2
Copy link

@jcgay Thank you, it does work!

@jcgay
Copy link
Owner

jcgay commented Oct 28, 2018

And this is an issue with jPowershell : profesorfalken/jPowerShell#33

It should be fixed in send-notification next release.

@jcgay jcgay closed this as completed in b67f9bd Oct 28, 2018
@pun-ky
Copy link
Author

pun-ky commented Oct 28, 2018

Thanks!

@pun-ky
Copy link
Author

pun-ky commented Oct 28, 2018

What is ETA for next release?

jcgay added a commit that referenced this issue Oct 28, 2018
Fixes #10

A `null` file (with content 'Active code page: 1252') was created when trying to run BurntToast with jPowerShell.
@jcgay
Copy link
Owner

jcgay commented Oct 28, 2018

It is released as v0.15.0, can you check that it is ok for you ?

@withparadox2 I have also released gradle-notifier v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants