Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color and Font Specs for content #36

Closed
CarlsoFiorention opened this issue Aug 26, 2020 · 19 comments
Closed

Color and Font Specs for content #36

CarlsoFiorention opened this issue Aug 26, 2020 · 19 comments

Comments

@CarlsoFiorention
Copy link
Collaborator

Please use these specs guidelines for visual consistency

specs copy.pdf

@jchartrand
Copy link
Collaborator

@sfarnel @CarlsoFiorention

You list two font options in the 'specs copy.pdf' file (https://github.com/jchartrand/can-link/files/5132755/specs.copy.pdf):

News Gothic Medium

or

News Cycle Medium

and say the second (News Cycle Medium) is open source.

I'm not sure what are the implications of the open source vs non open source ?

Would we, for example, have to pay for the News Gothic Medium?

This seems probably like a discussion for Carlos and Sharon?

@sfarnel
Copy link
Member

sfarnel commented Sep 1, 2020

Thanks James. @CarlsoFiorention can you provide details on options and implications? We certainly do not want to be in a scenario where we need to pay for usage. Thanks!

@CarlsoFiorention
Copy link
Collaborator Author

CarlsoFiorention commented Sep 1, 2020 via email

@jchartrand
Copy link
Collaborator

Should we just go with News Cycle to be safe?

If so, then just to be sure, is this it:

https://fonts.google.com/specimen/News+Cycle

?

And this should be used everywhere in the site?

@CarlsoFiorention
Copy link
Collaborator Author

CarlsoFiorention commented Sep 1, 2020 via email

@sfarnel
Copy link
Member

sfarnel commented Sep 1, 2020

Sounds great; thanks both!

@jchartrand
Copy link
Collaborator

I've changed the global font to News Cycle, and set the default font size for body text, etc. to 10.

It will take me a bit longer to go through all the titles, etc. and change those to 12.

But, if you could take a look at confirm that things are looking as they should, that would be great.

The colours will be a fair bit harder for the visualizations etc. I'll have to do those widget by widget and I should probably wait until we are working on each of those visualizations individually.

@jchartrand jchartrand reopened this Sep 1, 2020
@CarlsoFiorention
Copy link
Collaborator Author

CarlsoFiorention commented Sep 1, 2020 via email

@jchartrand
Copy link
Collaborator

Okay, I've changed the document list to 12, and most everything else I could see has been changed. I may have missed some things though, so just let me know.

@sfarnel
Copy link
Member

sfarnel commented Sep 1, 2020

Thanks James. @CarlsoFiorention can you review with your keen eye? Thanks!

@CarlsoFiorention
Copy link
Collaborator Author

Just a few things on type:

  • Make "about, "contact" and "search" size 11
  • Make the widgets labels also size 11
  • Reduce "Page 1 of ..." to size 10

@jchartrand
Copy link
Collaborator

Made the requested changes, i.e.,

Make "about, "contact" and "search" size 11
Make the widgets labels also size 11
Reduce "Page 1 of ..." to size 10

@CarlsoFiorention
Copy link
Collaborator Author

CarlsoFiorention commented Sep 2, 2020 via email

@sfarnel
Copy link
Member

sfarnel commented Sep 3, 2020

@jchartrand it looks like the specs related to a selected item in the results list have not been implemented. can you see if anything not related to a specific widget has been done? Thanks!

@jchartrand
Copy link
Collaborator

@sfarnel Hi Sharon, I'm not sure what you mean in your last comment, i.e.,

"it looks like the specs related to a selected item in the results list have not been implemented. can you see if anything not related to a specific widget has been done? Thanks!"

@sfarnel
Copy link
Member

sfarnel commented Sep 3, 2020

Sorry James. I was just looking at the specs document from Carlos and noticed that he had info on come colouring for when an item is selected. That seemed to me to be unrelated to a specific widget so thought it might make sense to take care of it now before diving into specs for each widget, which you noted might make sense to do one at a time. Does that help clarify?

@CarlsoFiorention
Copy link
Collaborator Author

CarlsoFiorention commented Sep 3, 2020 via email

@jchartrand
Copy link
Collaborator

jchartrand commented Sep 3, 2020 via email

@sfarnel
Copy link
Member

sfarnel commented Sep 21, 2020

Remaining items addressed in fine tuning issue(s); closing.

@sfarnel sfarnel closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants