You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implemenation of Command is case-sensitive. E.g. if I register a command help, I should send exact command help, but not Help or HELP. It's unusual.
So, why don't make it case-insensitive by adding modifier i inside getCommand method?
This $find = '/^'.preg_quote($commandName).'/';
Change to this $find = '/^'.preg_quote($commandName).'/i';
The text was updated successfully, but these errors were encountered:
I don't think it's unusual but maybe we can make it optional.
Inside the configure() method for a given command, we can set this option.
By default, it's still case-sensitive.
protectedfunctionconfigure() {
$this->setName('help');
$this->setCaseInsensitive(true); // Now it works with help, Help and HELP
}
Current implemenation of Command is case-sensitive. E.g. if I register a command
help
, I should send exact commandhelp
, but notHelp
orHELP
. It's unusual.So, why don't make it case-insensitive by adding modifier
i
insidegetCommand
method?This
$find = '/^'.preg_quote($commandName).'/';
Change to this
$find = '/^'.preg_quote($commandName).'/i';
The text was updated successfully, but these errors were encountered: