[JCLOUDS-1010] use a lightweight image as a base for Docker build test #208
Conversation
kwart
force-pushed
the
JCLOUDS-1010-dropbear
branch
from
fede734
to
9a9d205
Compare
| # SSH login fix. Otherwise user is kicked off after login | ||
| RUN sed 's@session\s*required\s*pam_loginuid.so@session optional pam_loginuid.so@g' -i /etc/pam.d/sshd | ||
| FROM alpine:3.2 | ||
| MAINTAINER JClouds Dev <jclouds-dev@apache.org> |
There was a problem hiding this comment.
[minor] Change to dev@jclouds.apache.org
There was a problem hiding this comment.
fixed
On Thu, Oct 8, 2015 at 11:47 AM, Ignasi Barrera notifications@github.com
wrote:
In docker/src/test/resources/Dockerfile
#208 (comment):-# SSH login fix. Otherwise user is kicked off after login
-RUN sed 's@session\s_required\s_pam_loginuid.so@session optional pam_loginuid.so@g' -i /etc/pam.d/sshd
+FROM alpine:3.2
+MAINTAINER JClouds Dev jclouds-dev@apache.org[minor] Change to dev@jclouds.apache.org
—
Reply to this email directly or view it on GitHub
https://github.com/jclouds/jclouds-labs/pull/208/files#r41494980.
|
lgtm. Thanks @kwart! |
kwart
force-pushed
the
JCLOUDS-1010-dropbear
branch
2 times, most recently
from
5abdb8b
to
a348e93
Compare
|
Looks like a transient failure: rebuild please |
kwart
force-pushed
the
JCLOUDS-1010-dropbear
branch
from
a348e93
to
d088ee5
Compare
| @Named("image:tag") | ||
| @POST | ||
| @Path("/images/{name}/tag") | ||
| @Fallback(FalseOnNotFoundOr404.class) |
There was a problem hiding this comment.
In general we try to avoid using 404 fallbacks in POST/PUT methods, as often they don't provide the right feedback to the user. Operations done on objects that are supposed to exist will already throw a ResourceNotFoundException. I'd change this method to return void and remove the fallback.
|
lgtm. Just some small comments in the tests. |
kwart
force-pushed
the
JCLOUDS-1010-dropbear
branch
from
d088ee5
to
ea7af71
Compare
|
Commits edited according to the comments. |
|
Pushed to msater and 1.9.x. Thanks! |
JIRAs:
JCLOUDS-1010
To limit bandwidth during running Docker provider live tests a lightweight image is used. The originally used Ubuntu image with OpenSSH server was replaced by Alpine Linux with dropbear SSH server.
JCLOUDS-1017
Implement
tagImageinImageApiof Docker provider.JCLOUDS-1020
Fix query parameter for adding image tag in
BuildOptionsclass (Docker provider).