This repository has been archived by the owner on Jul 25, 2020. It is now read-only.
JCLOUDS-987: Create security groups in AWS if subnetId is specified #858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/JCLOUDS-987
The changes required to make this work are basically:
The changes are pretty straightforward, but there is a subtle change: AWS-EC2 and the generic EC2 providers have a cache
"region/group" -> String
where the resulting String is the security group name for that group. In AWS-EC2 now the resulting String is the security group ID instead of its name, allowing the creation of security groups in VPCs (and saving an API call in most cases). The id form is always used to create security groups in AWS-EC2 (the generic EC2 provider remains unchanged as there is no VPC support there).@abayer a quick review would be highly appreciated.
@richardcloudsoft Could you test if this change fixes the issue?