Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small type hint and style issues #54

Closed
jcrozum opened this issue May 2, 2023 · 2 comments
Closed

Small type hint and style issues #54

jcrozum opened this issue May 2, 2023 · 2 comments

Comments

@jcrozum
Copy link
Owner

jcrozum commented May 2, 2023

I've fixed a lot of the type hinting stuff so that we can be quite strict with our type checkers, but there are still a couple of issues to work out:

  1. Type hinting and linting in the unit test files are not quite as rigorous as in the main library.
  2. In space_utils.expression_to_space_list the types of the pyeda objects are still mysterious to me. I just ignore them during type checking for now.
@jcrozum
Copy link
Owner Author

jcrozum commented May 4, 2023

We should also run everything through a linter eventually. There are lots of small PEP8 violations, like trailing whitespace and docstring formatting issues. A low priority, but something we should fix before full release.

@jcrozum
Copy link
Owner Author

jcrozum commented Aug 2, 2023

I did this in #74, so it should all be more or less OK now. There are probably still a few issues with pyeda types and the auto-generated type stubs almost certainly have some errors, but things are passing strict linting and type checks now.

@jcrozum jcrozum closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant