Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling on macOS #1004

Open
smaticka opened this issue Feb 12, 2024 · 7 comments
Open

Exception handling on macOS #1004

smaticka opened this issue Feb 12, 2024 · 7 comments
Assignees
Labels
bug Something is not working INFRA JEDI Infrastructure

Comments

@smaticka
Copy link

smaticka commented Feb 12, 2024

Describe the bug

Exception handling is unknown when running JEDI on the mac. See this example after a change was made to an ObsFunction (.cc file) in ufo:

2007: OOPS_TRACE[0] Variables::Variables
2007: Unknown exception: oops::HofX3D<FV3JEDI, UFO and IODA observations> terminating...
2007: Unknown exception: oops::HofX3D<FV3JEDI, UFO and IODA observations> terminating...

alternately, the same change made on Orion resulted in this readout (more verbose):

2259: OOPS_TRACE[0] Variables::Variables
2259: Exception: Error: YAML validation failed.
2259:   Location:      /observations/observers/0/obs filters/0/filter
2259:   Invalid value: "Variable Transform"
2259:   Cause:         unrecognized enum value
2259: Exception: oops::HofX3D<FV3JEDI, UFO and IODA observations> terminating...
2259: Exception: Error: YAML validation failed.
2259:   Location:      /observations/observers/0/obs filters/0/filter
2259:   Invalid value: "Variable Transform"
2259:   Cause:         unrecognized enum value
2259: Exception: oops::HofX3D<FV3JEDI, UFO and IODA observations> terminating...

To Reproduce
I'm not sure if this will reproduce it, but this is what I did:
built the jedi-bundle (internal) on the mac (see system) with spack-stack-1.5.1 with IODA converters turned on.
Received many warnings during build (see section below).

Expected behavior
The exception handling on the macOS should be more verbose (similar to the handling on Orion).

System:
mac M2 chip. macOS ventura 13.4. spack-stack-1.5.1

Additional context
When building the jedi-bundle (internal) on the mac, I received many warnings indicating this:
ld: warning: could not create compact unwind for...
From googling, it seems like that could lead to poor exception handling.

@smaticka smaticka added the bug Something is not working label Feb 12, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Feb 12, 2024
@smaticka
Copy link
Author

@srherbener and @climbfuji

I tried rebuilding on my mac (complete new directory) with these lines uncommented in the jedi-bundle/CMakeList.txt file:

ecbuild_bundle( PROJECT eckit    GIT "https://github.com/ecmwf/eckit.git" TAG 1.24.4 )
ecbuild_bundle( PROJECT fckit    GIT "https://github.com/ecmwf/fckit.git" TAG 0.11.0 )

and then unloaded the modules just in case with:

module unload fckit/0.11.0
module unload eckit/1.24.4

I still receive numerous of the ld: warning (in initial description), and the exception handling did not change.

@srherbener
Copy link
Collaborator

@smaticka thanks for submitting this issue, and for testing the in-bundle build. Bummer that the in-bundle build didn't fix it - that would have been a great clue. The INFRA team will continue investigating this and will keep you posted.

@srherbener srherbener self-assigned this Feb 26, 2024
@climbfuji
Copy link
Collaborator

@srherbener @smaticka Any update on this issue?

@smaticka
Copy link
Author

@climbfuji I still get a lot of ld: warnings when building and the exception handling is not verbose as it is on Orion. Essentially appears to be the same problem even with recent builds.

@climbfuji
Copy link
Collaborator

I honestly think this issue should be in JCSDA-internal fv3-jedi or jedi-bundle ...

@smaticka
Copy link
Author

@srherbener do you have a better idea of what repo might be the source of the problem? I can move the issue there.

@srherbener
Copy link
Collaborator

I think the exception messages are being thrown from eckit, but I doubt the problem we are seeing is coming from eckit.

What are you running when you see this symptom? Is it any particular ctest, or are you running an application (such as fv3jedi_hofx.x, or fv3jedi_var.x, etc)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working INFRA JEDI Infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants