-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Scripts: consider removing display:block from tables in github wikis #22
Comments
There's already a tweak in the script which uses ARIA roles to override
this. Removing display: block; is more risky, since it probably affects the
visual presentation. Obviously, GitHub changed something and that tweak is
no longer applying. That's not surprising - they keep changing the table
stuff - though it is kinda frustrating. :(
|
hmm, maybe my scripts are back level ... I'll update and retry! |
Jamie, it's strange. I updated tamper monkey and made sure the github scripts are up-to-date. Still, the tables in the aria-practices wiki are not getting rendered as tables. |
I believe you. To be clear, there is a tweak in the scripts to deal with
this, but I guess GitHub changed something and that tweak no longer matches
properly, which doesn't surprise me in the slightest. I'll need to figure
out what they changed and adapt accordingly.
|
These tables behave fine with latest Firefox and Chrome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In github wikis, if you create a table in markdown, for instance in a mediawiki page, github renders it with display:block. As a result, the table is not recognized as a table in Firefox or Chrome.
For an example of this, see the release plans page in the aria-practices wiki. There is a table under the heading "Plans by Version and Release". However, it is not readable as a table when using Firefox or Chrome.
I also reported this to github because I do not think it is appropriate to apply display:block to all wiki tables by default. Further, it is debatable whether or browsers should hide the table semantics based on the display:block styling. For instance, see Firefox bug 1005271.
Until there is some change in Github or in Firefox or Chrome, the only way to read tables in the github wikis is to use IE, which is not really a practical option. So removing or overriding the display:block from the tables would be super helpful!
The text was updated successfully, but these errors were encountered: