Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice to know if there's errors without checking all of the tabs. #12

Open
xymostech opened this issue Jun 10, 2015 · 4 comments

Comments

@xymostech
Copy link

Is it possible to add an error counter badge to the tota11y button as well as in the different plugin rows with the number of errors for that plugin?

@kevinbarabash
Copy link

+1 Maybe the green checkmark could be repurposed to show which plugins are happy. When you click on it, it would just highlight that row in the plugin list.

@jdan jdan closed this as completed Jun 11, 2015
@jdan jdan reopened this Jun 11, 2015
@jdan
Copy link
Owner

jdan commented Jun 16, 2015

I'm hesitant to add this because a fair amount of tota11y plugins will not be reporting errors. My long-term plans are to add substantial visualization tools, such as:

  • A tool that displays what a screen reader would read off as the user hovers over elements
  • A tool that helps visualizes focus styles (or lack thereof) on hover
  • A tool that helps visualize the tab order of the site

Landmarks does not currently report any errors.

The current set of plugins are low-hanging fruit, and consequently point out errors resembling those of automated testing solutions.

The current use case is to check through some plugins and fix errors if they pop up, but there are existing audit tools which cater more towards the "Here's a billion errors, now try to fix them" use-case. I'm not attempting to compete with those tools because they have not worked well for us at KA.

@xymostech
Copy link
Author

Hmm, interesting. I guess you wouldn't want to highlight that there are errors so much that people don't look at the plugins that don't report errors. The visualization tools

I guess my main concern is that it's easy for me to miss that there's an error in something that I wasn't expecting; like maybe I added a bunch of links so I keep checking the "Link text" tab to see if there's any errors, but I totally miss that I've added a bunch of contrast violations along the way. Maybe just putting a small warning sign next to the plugins that are reporting errors or something, just to make it more discoverable that errors exist?

@jdan
Copy link
Owner

jdan commented Sep 14, 2015

Been thinking about this more and I'm starting to like the idea of putting a small "warning icon" next to the plugin if there's an error. I'll have to do some refactoring to allow plugins to run without any user interaction (and without rendering error labels).

I think it'll draw some attention to the plugins though! Great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants