Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklet -"TypeError: Cannot read property 'trim' of null" for Link Text and Labels tools #23

Closed
redking opened this issue Jun 29, 2015 · 4 comments

Comments

@redking
Copy link

redking commented Jun 29, 2015

Hey,

I'm having an issue with the bookmarklet when using the Link Text and Labels tools. When I click on either, I see the following error in the console

Uncaught TypeError: Cannot read property 'trim' of null

arising from this line of code

return "" === axs.properties.findTextAlternatives(a, {}).trim() ? !1 : !0;

The expression axs.properties.findTextAlternatives(a, {}) is returning null.

I see this error on a number of sites - Gmail, for example. Curiously enough, both tools work fine when I test on http://khan.github.io/tota11y/

I'm using the latest version of Chrome.

@jdan
Copy link
Owner

jdan commented Jun 29, 2015

Thanks for reporting @redking. I've seen this issue myself a few times - looks like a bug upstream in Accessibility Developer Tools.

We could probably change how we consume their API, though, in the meantime.

@jdan
Copy link
Owner

jdan commented Jul 22, 2015

Fix coming soon upstream. GoogleChrome/accessibility-developer-tools#188

@jdan
Copy link
Owner

jdan commented Sep 14, 2015

This is fixed and landed on master. Will close this once I put up a new build!

@jdan
Copy link
Owner

jdan commented Sep 17, 2015

@redking Just pushed out a new version of tota11y, powered by a newer version of Accessibility Developer Tools. This issue seems fixed, but please let me know if you see it again!

@jdan jdan closed this as completed Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants