-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native methods for bit access #70
Comments
Again - why? This will slow down things on most platforms and make code much more polluted. |
How will it slow down things on most platforms? |
I already said in another thread - native |
If you're willing to create issue that doesn't reveal some actual bug, but is request for performance improvement, please add corresponding benchmarks so that we both don't waste time discussing theoretical questions and/or explaining something. Just "use something" without any ground or proof behind is counter-productive, so I'm closing this and similar issues for now. |
https://github.com/jDataView/jDataView/blob/master/src/jdataview.js#L574
_getBytes produces unnecessary garbage. Please use native methods when possible. (e.g. if bitLength <= 8 use getUint8, if bitLength <= 16 use getUint16, etc)
The text was updated successfully, but these errors were encountered: