Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods #136

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Conversation

saturnism
Copy link
Member

@saturnism saturnism commented Oct 28, 2017

For #115


This change is Reviewable

@saturnism saturnism changed the base branch from master to 2.x October 28, 2017 21:57
@aalmiray
Copy link
Contributor

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


subprojects/jdeferred-core/src/main/java/org/jdeferred/DeferredManager.java, line 603 at r1 (raw file):

	 * A convenience method create a {@link Promise} that immediately resolves to a value.
	 *
	 * @since 2.0

we should add @since 2.0 to all new variations of when(), also race and settle. New interfaces such as CallbackExceptionHandler, CancellationHandler` and their setters should be marked too


Comments from Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 54.812% when pulling 1ad6c1f on saturnism:88-convenience into 395e988 on jdeferred:2.x.

@saturnism
Copy link
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


subprojects/jdeferred-core/src/main/java/org/jdeferred/DeferredManager.java, line 603 at r1 (raw file):

Previously, aalmiray (Andres Almiray) wrote…

we should add @since 2.0 to all new variations of when(), also race and settle. New interfaces such as CallbackExceptionHandler, CancellationHandler` and their setters should be marked too

Agreed! I noticed we didn't have that :( Added #137


Comments from Reviewable

@saturnism saturnism closed this Oct 28, 2017
@saturnism saturnism reopened this Oct 28, 2017
@saturnism saturnism merged commit 38d8953 into jdeferred:2.x Oct 28, 2017
@saturnism saturnism deleted the 88-convenience branch October 28, 2017 22:08
@saturnism saturnism mentioned this pull request Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants