Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin-side JavaScript conflict with other plugins #95

Closed
erommel opened this issue Jul 26, 2020 · 0 comments · Fixed by #99
Closed

Admin-side JavaScript conflict with other plugins #95

erommel opened this issue Jul 26, 2020 · 0 comments · Fixed by #99

Comments

@erommel
Copy link
Contributor

erommel commented Jul 26, 2020 •
edited
Loading

Hi team.

Problem

Currently, the plugin loads admin-side JavaScript on every page of the Dashboard
https://github.com/Yoast/clicky/blob/1865da9557244ebfad5f2973e7cd8b44de7c3d11/admin/admin-page.php#L21-L22
https://github.com/Yoast/clicky/blob/1865da9557244ebfad5f2973e7cd8b44de7c3d11/admin/admin-page.php#L30-L39

Since some plugins (like ours) are using URL hashes in navigation, this causes JS error, which breaks functionality of our plugins.

Solution

Load admin-side scripts on plugin settings page only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load admin-side scripts on settings page only jdevalk/clicky
1 participant
@erommel