Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create <EditableRichTile /> #44

Closed
jdevries3133 opened this issue Mar 30, 2021 · 7 comments
Closed

Create <EditableRichTile /> #44

jdevries3133 opened this issue Mar 30, 2021 · 7 comments
Labels
frontend javascript, React, Redux, styled-components, etc. help wanted Newcomers *always* welcome! #34 Wireframe Implementation See wireframes under issue #34 for details on how to complete this issue.
Milestone

Comments

@jdevries3133
Copy link
Owner

Part of #34 project. See #34 for wireframe.

@jdevries3133 jdevries3133 added help wanted Newcomers *always* welcome! #34 Wireframe Implementation See wireframes under issue #34 for details on how to complete this issue. labels Mar 30, 2021
@mmulet
Copy link
Contributor

mmulet commented Mar 31, 2021

I saw the help wanted tag, so I created a code relay task for this here: https://github.com/code-relay-io/song_maker_gallery/blob/main/README.md . So, we will work on this.

@jdevries3133
Copy link
Owner Author

@mmulet I hope someone would jump in on this, that would be fantastic! If anyone sees this, I just finished setting up storybook in my latest commit, so that should make developing this component in isolation a breeze if you want to take it on.

@mmulet
Copy link
Contributor

mmulet commented Apr 1, 2021

@jdevries3133 Great! We've had one commit already, they said the storybook and CONTRIBUTING.md were very helpful!
Code relay just started so we don't have a lot of users right now, so I can't say how fast we'll finish the issue, but I will send javascript/react programmers to this issue as they come in.

@jdevries3133
Copy link
Owner Author

@mmulet Awesome well, there is no rush and I really appreciate the help. I still need to do all the other components in that wireframe + backend implementation, etc, so it will be a while before this issue is hanging anything up.

It's funny that I got storybook set up around the same exact time you came to help – very serendipitous!

I'm glad the contributing guide was helpful I updated it (slightly) and it also now references some new details on how to implement the wireframes which lives in the thread for #34.

Thanks again!

@jdevries3133
Copy link
Owner Author

@mmulet can I get a PR on what has been done so far? I know it's just a little setup work, but at least it'll get the contributor into the commit history.

As you can see, I'm wrapping up on these wireframes so I'm getting to the point of wanting to move forward with this.

@mmulet
Copy link
Contributor

mmulet commented Apr 20, 2021

Sorry to take so long to get back to you. We've had one commit so far, sorry that it's so slow, we'll still growing.
Everything is here: https://github.com/code-relay-io/song_maker_gallery/blob/main/README.md

@jdevries3133
Copy link
Owner Author

@mmulet that's ok! I went ahead and pulled your commit in to this repo. For future contributors on your fork, they should be sure to pull from upstream because I keep making changes to this part of the project as I work on the gallery form (#41)

@jdevries3133 jdevries3133 added this to the Version 3 milestone Apr 21, 2021
@jdevries3133 jdevries3133 added javascript frontend javascript, React, Redux, styled-components, etc. and removed javascript labels Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript, React, Redux, styled-components, etc. help wanted Newcomers *always* welcome! #34 Wireframe Implementation See wireframes under issue #34 for details on how to complete this issue.
Projects
None yet
Development

No branches or pull requests

2 participants