resolve API disconnects #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resolves the plugin disconnecting from the Ecobee servers. Even if there is an authentication error—for example, the Ecobee API servers are down—the tokens shouldn't be removed so the plugin can keep trying to refresh. The access token should only be cleared once the refresh_token is missing. The current code will erase the tokens any time the API servers go down, preventing any future refreshes.
|
This would be great to see merged. I run into this issue myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves the plugin disconnecting from the Ecobee servers. With the current code, any time the Ecobee API servers are offline (for maintenance, network errors, etc.) the refresh and access token are erased. This prevents the plugin from making any future updates without reauthentication.
Instead the tokens shouldn't be removed so the plugin can keep trying to refresh. The access token should only be cleared once the refresh_token is missing. I have been successfully running with this change for ~4 months.