Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowRegression error estimation is incredibly slow #3

Closed
jdidion opened this issue Dec 3, 2016 · 1 comment
Closed

ShadowRegression error estimation is incredibly slow #3

jdidion opened this issue Dec 3, 2016 · 1 comment

Comments

@jdidion
Copy link
Owner

jdidion commented Dec 3, 2016

Currently we call out to the R package for the calculations. It is research code and probably not optimized for performance. I should be reimplemented in cython.

@jdidion
Copy link
Owner Author

jdidion commented Jan 6, 2018

Closing this. The Wang et al. Shadow Regression method should be considered deprecated and will be removed in a future version, in favor of a native python or Cython implementation of the Zhu et al. cubic spline method: https://bmcbioinformatics.biomedcentral.com/articles/10.1186/s12859-016-1052-3 (or a better method, if one exists by the time I get around to implementing it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant