Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building in MSVC2017 (Windows 10 x64): _mkdir #7

Closed
DJuego opened this issue May 6, 2019 · 2 comments
Closed

Building in MSVC2017 (Windows 10 x64): _mkdir #7

DJuego opened this issue May 6, 2019 · 2 comments

Comments

@DJuego
Copy link

DJuego commented May 6, 2019

Hi! Thank you for this apparenty excellent contribution! :-)

I work in Windows 10 x64 with Microsoft Visual Studio 2017 and I have a problem with the gaga compilation:

1>------ Build started: Project: prueba_gaga_msvc2017, Configuration: Release x64 ------
1>main.cpp
1>p:\mis-proyectos\personal\prueba_gaga\inc\gaga\gaga.hpp(1617): error C2065: '_mkdir': undeclared identifier
1>p:\mis-proyectos\personal\prueba_gaga\inc\gaga\gaga.hpp(1617): error C3861: '_mkdir': identifier not found
1>p:\mis-proyectos\personal\prueba_gaga\inc\gaga\gaga.hpp(1617): note: '_mkdir': function declaration must be available as none of the arguments depend on a template parameter


I have added to gaga.hpp the lines:

#ifdef _WIN32
#include<direct.h>
#else

#endif

It seems work. At least the code compiles.

Thank you again!
DJuego

@jdisset
Copy link
Owner

jdisset commented Sep 9, 2020

GAGA is now "officially" a C++17 library, and all the file & directory operations have been handed over to std::filesystem. This should fix most of the portability issues as long as you have a recent enough compiler.
I haven't had the occasion to test it on Windows but it should work. I'd appreciate if you can try again on your setup.

@DJuego
Copy link
Author

DJuego commented Sep 10, 2020

Yes, I can confirm that it works! Thanks for taking a look at this.

DJuego

@jdisset jdisset closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants