-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips for sub-category folder #143
Conversation
@pujiaxun Sounds great. Would you mind to attach a screenshot in the PR? |
@pujiaxun Just one small comment. |
import * as os from "os";
//...
return [
`AC: ${numAC}`,
`Not AC: ${numNotAC}`,
`Unknown: ${numUnknown}`,
`Total: ${problems.length}`,
].join(os.EOL); Like this? @jdneo |
@pujiaxun Yes, looks much better. |
@jdneo Any other suggestions? For instance, I think the name "Not AC" sounds weird... |
@pujiaxun hmm, good question. Regarding the wording. My suggestion is Either |
@jdneo I prefer to keep |
Same to me. So let's keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pujiaxun LGTM. Thank you for your contribution. Nice work.
Background: I wonder how many problems I have solved. Then I found the tooltip field is available for now. That's it~