You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I used goenrich.enrich.analyze(O, query_genes, 'Background', method='bonferroni') I was surprised to find that the q values were actually lower than the p values. Is it possible the math in your bonferroni correction is backwards?
if method == 'bonferroni':
q[mask] = p / len(p)
where it should probably be q[mask] = min(1, p * len(p))
The text was updated successfully, but these errors were encountered:
Well spotted! You are definitely correct. I'll try to find some time to apply the fix, or you can go ahead and make a pull request. Thank you for reporting this.
When I used
goenrich.enrich.analyze(O, query_genes, 'Background', method='bonferroni')
I was surprised to find that the q values were actually lower than the p values. Is it possible the math in your bonferroni correction is backwards?where it should probably be
q[mask] = min(1, p * len(p))
The text was updated successfully, but these errors were encountered: