Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VG does not discard state since bgfx commit 0881d98b #19

Closed
hugoam opened this issue Apr 12, 2020 · 1 comment
Closed

VG does not discard state since bgfx commit 0881d98b #19

hugoam opened this issue Apr 12, 2020 · 1 comment

Comments

@hugoam
Copy link
Contributor

hugoam commented Apr 12, 2020 •
edited
Loading

bgfx::submit() old preserveState parameter has been changed to a semantically opposite meaning, it is now a discard parameter, since this commit: bkaradzic/bgfx@0881d98
This causes vg-renderer to silently always preserve state, when it intends to always discard it.
All instances of bgfx::submit() with two last arguments being 0, false should be fixed. (those parameters have default values, so in the future it is actually safer to omit them, to avoid a similar issue happening in the future)
@hugoam
Copy link
Contributor Author

hugoam commented Apr 12, 2020

This should solve it
#20

@hugoam hugoam mentioned this issue Apr 12, 2020
Merged
@jdryg jdryg closed this as completed Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdryg @hugoam