Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources/outputs can't point to a specific path #1372

Closed
fiadliel opened this issue Jan 5, 2024 · 2 comments · Fixed by #1509
Closed

Sources/outputs can't point to a specific path #1372

fiadliel opened this issue Jan 5, 2024 · 2 comments · Fixed by #1509
Labels
bug Something isn't working
Milestone

Comments

@fiadliel
Copy link
Contributor

fiadliel commented Jan 5, 2024

Describe the bug
Sources and outputs are used as inputs to "globwalk", which does a recursive search for files matching the string. There doesn't seem to be a way to opt out of this, and provide a real relative path.

To Reproduce
Include a config which includes sources and outputs like

[tasks.bug]
sources = [ 'style.css' ]
outputs = [ 'outputs/style.css' ]

This task will always trigger, because outputs/style.css is also included in the last modified calculation for sources.

Expected behavior
It should be possible to specify an actual path, rather than a search path. The behavior and syntax should be clear in documentation. One approach used by some libraries (e.g. glob) is that **/ triggers a subdirectory match.

@fiadliel fiadliel added the bug Something isn't working label Jan 5, 2024
@jdx
Copy link
Owner

jdx commented Jan 5, 2024

not surprising, I forgot to test with non-wildcards

@fiadliel
Copy link
Contributor Author

fiadliel commented Jan 6, 2024

Understood 🙂 Not a blocker for me to use, I was just scratching my head over why detection change didn't seem to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants