Ensure the e2e tests pass in the dev container #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required by the e2e test of pipx, which uses system packages.
jdx
reviewed
Apr 23, 2024
| @@ -112,7 +112,7 @@ run = 'docker build $root -f $root/packaging/dev/Dockerfile -t ghcr.io/jdx/mise: | |||
|
|
|||
| [tasks."docker:cargo"] | |||
| description = "run cargo inside of development docker container" | |||
| run = 'docker run -ti --rm -v $root:/mise -w /mise ghcr.io/jdx/mise:dev cargo' | |||
| run = 'docker run -ti --rm -e "GITHUB_API_TOKEN=${GITHUB_API_TOKEN:-}" -v $root:/mise -w /mise ghcr.io/jdx/mise:dev cargo' | |||
There was a problem hiding this comment.
I may have merged too early, I think this would've done the same thing but cleaner:
docker run -ti --rm -e GITHUB_API_TOKEN
https://docs.docker.com/reference/cli/docker/container/run/#env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early, draft pull request.
As discussed on discord, its purpose is to have the e2e tests passing in the dev container, and also to use this container to run all the e2e tests in CI.