Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the e2e tests pass in the dev container #1942

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Ensure the e2e tests pass in the dev container #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e173d
fix(devcontainer): install python3-venv.
Adirelle Apr 23, 2024
74efca7
fix(docker:e2e): pass any GITHUB_API_TOKEN to the e2e test container.
Adirelle Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ run = 'docker build $root -f $root/packaging/dev/Dockerfile -t ghcr.io/jdx/mise:

[tasks."docker:cargo"]
description = "run cargo inside of development docker container"
run = 'docker run -ti --rm -v $root:/mise -w /mise ghcr.io/jdx/mise:dev cargo'
run = 'docker run -ti --rm -e "GITHUB_API_TOKEN=${GITHUB_API_TOKEN:-}" -v $root:/mise -w /mise ghcr.io/jdx/mise:dev cargo'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have merged too early, I think this would've done the same thing but cleaner:

docker run -ti --rm -e GITHUB_API_TOKEN

https://docs.docker.com/reference/cli/docker/container/run/#env


[tasks."docker:mise"]
description = "run mise inside of development docker container"
Expand Down
2 changes: 2 additions & 0 deletions packaging/dev/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ RUN apt-get update \
direnv \
fd-find \
fish \
python3-venv \
&& ln -s /usr/bin/{fdfind,fd} \
&& mkdir -p /etc/apt/keyrings \
&& curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \
Expand All @@ -44,6 +45,7 @@ RUN apt-get update \
&& cargo -V \
&& node -v \
&& npm -v \
&& python3 -v \
&& just --version
# && mkdir -p $dev/cargo \
# && mv "$CARGO_HOME/registry" $dev/cargo/registry && ln -s $dev/cargo/registry "$CARGO_HOME/registry" \
Expand Down
Loading