Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip kernel_setup_interface when skip-kernel-setup is set #67

Closed
mweinelt opened this issue Nov 24, 2020 · 2 comments
Closed

skip kernel_setup_interface when skip-kernel-setup is set #67

mweinelt opened this issue Nov 24, 2020 · 2 comments

Comments

@mweinelt
Copy link
Contributor

The skip-kernel-setup functions does not skip setting up the rp_filter setting in kernel_setup_interface. This prevents babeld from working as an unprivileged user with CAP_NET_ADMIN only.

Please make setting the rp_filter per interface conditional on skip-kernel-setup.
@mweinelt

This comment has been minimized.

Sign in to view
mweinelt added a commit to mweinelt/babeld that referenced this issue Nov 24, 2020
@mweinelt
Skip kernel_setup_interface when skip-kernel-setup is enabled.
6bec435 
Setting sysctls is not allowed for unprivileged users, so let's not try
to set per interface rp_filter when `skip-kernel-setup` is set.

After this change babeld can run as an unprivileged users with
CAP_NET_ADMIN. The user needs to take care of setting up the sysctls
themselves.

Fixes: jech#67
@mweinelt mweinelt mentioned this issue Nov 24, 2020
Closed
@jech
Copy link
Owner

jech commented Dec 20, 2020

Fixed in f9698a5.

@jech jech closed this as completed Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip kernel_setup_interface when skip-kernel-setup is enabled. mweinelt/babeld
2 participants
@mweinelt @jech