Skip kernel_setup_interface when skip-kernel-setup is enabled.
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting sysctls is not allowed for unprivileged users, so let's not try to set per interface rp_filter when `skip-kernel-setup` is set. After this change babeld can run as an unprivileged users with CAP_NET_ADMIN. The user needs to take care of setting up the sysctls themselves. Fixes: jech#67
10 tasks
|
Thanks. Slightly edited and committed (under your name) as f9698a5. |
mweinelt
added a commit
to mweinelt/nixpkgs
that referenced
this pull request
Apr 24, 2021
This is in preparation to run babeld as DynamicUser and was submitted upstream in jech/babeld#68 and will be part of the 1.10 release.
mweinelt
added a commit
to mweinelt/nixpkgs
that referenced
this pull request
Apr 24, 2021
The last bits to prevent babeld from running unprivileged was its kernel_setup_interface routine, that wants to set per interface rp_filter. This behaviour has been disabled in a patch that has been submitted upstream at jech/babeld#68 and reuses the skip-kernel-setup config option. → Overall exposure level for babeld.service: 1.7 OK 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting sysctls is not allowed for unprivileged users, so let's not try
to set per interface rp_filter when
skip-kernel-setupis set.After this change babeld can run as an unprivileged users with
CAP_NET_ADMIN. The user needs to take care of setting up the sysctls
themselves.
Fixes: #67