Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It slowed down a bit recently #22

Closed
hellojinwoo opened this issue Feb 27, 2019 · 4 comments
Closed

It slowed down a bit recently #22

hellojinwoo opened this issue Feb 27, 2019 · 4 comments
Labels

Comments

@hellojinwoo
Copy link

It used to be much faster to crawl data such as historical daily prices but recently, it slowed down a bit.

For ticker in ticker_list :  # ticker_list has 445 tickers in total
    yahoo_financials = YahooFinancials(ticker)
    historical_data = yahoo_financials.get_historical_price_data('2019-02-01','2019-02-25, 'daily')

For example, the code above took me about 20 minutes to complete.
Why did it slow down so much and can you handle this issue please?

@sylvandb
Copy link
Contributor

which version was okay and which version did the slow down happen?

if you didn't change version, the problem is not this code.

@hellojinwoo
Copy link
Author

I am using the most recent version, v1.5 and it seems that it slowed down after I installed the version v1.5.

@JECSand
Copy link
Owner

JECSand commented Feb 28, 2019

Hi hellojinwoo,

I will do some benchmarking between v1.4 and v1.5 over the coming weekend and get back to you about this. Thank you for bringing this to our attention!

@hellojinwoo
Copy link
Author

Now it got about 2 times faster than before! I don't know why but I will close this issue :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants