Only comment code added #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2012 12:47
Replaced the MoinMoin code, but commented, so that devs could easily replace it if they choose to. Also added comment descriptions to the new and old regex code.
Creating consistency. Corrected another instance of MoinMoin implying that all wiki's are opposed to linebreaks.
|
Hey jedie, is this pull request still open? |
|
Sorry for late response. It's noe merged ;) |
|
Ah, very good. I'm still working on integrating this library in my web framework. I've modified it so that urls are represented by numbers instead of page titles. (I don't want referring links going bad if the page title is changed) If I find any other good edits to make, I'll be sure to send them your way. :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made comments to the url regex, and re-added the old code in comment form for anyone that might wish to prefer the old code. Also changed "wiki" to "wikipedia" at another location, because not all wiki's are against using line breaks.