Only comment code added #10

Merged
merged 2 commits into from Nov 1, 2012

Conversation

Projects
None yet
3 participants
@Sepero
Contributor

Sepero commented Sep 4, 2012

Made comments to the url regex, and re-added the old code in comment form for anyone that might wish to prefer the old code. Also changed "wiki" to "wikipedia" at another location, because not all wiki's are against using line breaks.

Sepero added some commits Sep 4, 2012

Replaced orig code, but commented, added desc
Replaced the MoinMoin code, but commented, so that devs could easily replace it if they choose to. Also added comment descriptions to the new and old regex code.
Concept clarification in comments
Creating consistency. Corrected another instance of MoinMoin implying that all wiki's are opposed to linebreaks.
@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Sep 4, 2012

This pull request passes (merged 146f127 into 8645a5a).

This pull request passes (merged 146f127 into 8645a5a).

@Sepero

This comment has been minimized.

Show comment
Hide comment
@Sepero

Sepero Nov 1, 2012

Contributor

Hey jedie, is this pull request still open?

Contributor

Sepero commented Nov 1, 2012

Hey jedie, is this pull request still open?

jedie added a commit that referenced this pull request Nov 1, 2012

@jedie jedie merged commit 8d3af59 into jedie:master Nov 1, 2012

1 check passed

default The Travis build passed
Details
@jedie

This comment has been minimized.

Show comment
Hide comment
@jedie

jedie Nov 1, 2012

Owner

Sorry for late response. It's noe merged ;)

Owner

jedie commented Nov 1, 2012

Sorry for late response. It's noe merged ;)

@Sepero

This comment has been minimized.

Show comment
Hide comment
@Sepero

Sepero Nov 1, 2012

Contributor

Ah, very good. I'm still working on integrating this library in my web framework. I've modified it so that urls are represented by numbers instead of page titles. (I don't want referring links going bad if the page title is changed) If I find any other good edits to make, I'll be sure to send them your way. :) 👍

Contributor

Sepero commented Nov 1, 2012

Ah, very good. I'm still working on integrating this library in my web framework. I've modified it so that urls are represented by numbers instead of page titles. (I don't want referring links going bad if the page title is changed) If I find any other good edits to make, I'll be sure to send them your way. :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment