You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They appear to be similar, however one of the original reasons for creating accum was to provide an easy way to accumulate a stream which might contain multibyte string which has been split across buffer packets in a stream.
The proper way to handle that is to concatenate all the buffers first, then convert to string, otherwise the conversion of individual packets will result in a different (corrupted) result string.
Since this was an easy mistake this module was created to make that and other accumulations easier.
Since I didn't have a test for that multibyte split, the original code had regressed over time, but after a review today, I added a test and restored that original use case.
From my review of concat-stream, it suffers from the same flaw (if a multibyte char is split between buffers, it will result with wrong corrupted string).
What are the differences between this project and https://github.com/maxogden/concat-stream?
The text was updated successfully, but these errors were encountered: