NODE_ENV is always '' (empty string) in browser.

[renatomcamilio]

I ran into this issue where NODE_ENV is always !== "production", because when running in the browser window won't be undefined.

Check the code below:

redux-logic/src/createLogic.js

Line 24 in 1034a3e

const NODE_ENV = (typeof window === 'undefined' && process && process.env && process.env.NODE_ENV) ? process.env.NODE_ENV : '';

So, later on in the same file we reference it to decide whether to log warnings (using warnTimeout), and even in production builds we are seeing these logs:

redux-logic/src/createLogic.js

Lines 188 to 193 in 1034a3e

	if (NODE_ENV !== 'production' &&
	typeof processOptions.dispatchMultiple !== 'undefined' &&
	warnTimeout !== 0) {
	// eslint-disable-next-line no-console
	console.error(`warning: in logic for type(s): ${stringifyType(type)} - dispatchMultiple is always true in next version. For non-ending logic, set warnTimeout to 0`);
	}

I have a couple questions regarding the way we define NODE_ENV here:

1. why do we check for typeof window === 'undefined'? Is this just meant for the build/babel step?
2. I'm using CRA, can't overwrite NODE_ENV. Do you have a suggestion how to approach this?

[jeffbski]

@renatomcamilio Thanks for reaching out.

Regarding your questions:

1. Yes, this was for the build step
2. yes, I assume you are wanting to silence the warning logs.

When you create your logic, just set warnTimeout: 0 and this should silence all of those logs.