Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons improvements #203

Closed
sawjlab opened this issue Jun 12, 2017 · 2 comments
Closed

scons improvements #203

sawjlab opened this issue Jun 12, 2017 · 2 comments

Comments

@sawjlab
Copy link
Member

sawjlab commented Jun 12, 2017

The top SConscript.py file has a list, "hcheaders", for all the .h files in src. src/SConscript.py has a list, "list" of all the .cxx files in src. When a new class is added, both of these files must be updated. One of these lists should be automatically generated from the other.

Furthermore, it should be possible to avoid hand writing either of these lists. They could be generating from the file names of all the .cxx files in src.

Even more ideally, the file src/HallC_LinkDef.h which has a line for each class in it, could be generated automatically. If this is done, then Makefile should also be updated to autogenerate HallC_LinkDef.h and it's source code list "SRC".

@brash99
Copy link
Contributor

brash99 commented Jun 12, 2017

You may recall that I had implemented all of these suggested fixes a few months ago, and talked about it at one of the software meetings. I had not done a pull request, because there was the issue of requiring a fairly up-to-date version of scons to make it all work. I was going to check with Ole about this, and then also check which version was installed on JLab systems, to make sure that was ok as well. Let me revisit this over the next week, and provided everything is ok, I will do a pull request.

@sawjlab
Copy link
Member Author

sawjlab commented Jul 11, 2017

@brash99 addressed this issues in commit 3840ef2

@sawjlab sawjlab closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants