Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank connection when deployed? #33

Closed
joeyeng opened this issue Aug 29, 2018 · 9 comments
Closed

Blank connection when deployed? #33

joeyeng opened this issue Aug 29, 2018 · 9 comments

Comments

@joeyeng
Copy link
Contributor

joeyeng commented Aug 29, 2018

After deploying the generated template my connection had blank values:

"$connections": {
        "value": {
            "azureblob_1": {
                "connectionId": "",
                "connectionName": "",
                "id": ""
            }
        }
    }

Here's how it was defined in the template:

"parameters": {
          "$connections": {
            "value": {
              "azureblob-1": {
                "id": "[concat('/subscriptions/',subscription().subscriptionId,'/providers/Microsoft.Web/locations/',parameters('logicAppLocation'),'/managedApis/azureblob')]",
                "connectionId": "[resourceId('Microsoft.Web/connections', parameters('azureblob-1_name'))]",
                "connectionName": "[parameters('azureblob-1_name')]"
              }
            }
          }
        }

Did I do something wrong or is this a known limitation?

@MLogdberg
Copy link
Collaborator

Hi, not sure exactly how you mean, was the lower code snippet how the ARM template looked like when deploying? Since that seems correct according too me.

@joeyeng
Copy link
Contributor Author

joeyeng commented Aug 31, 2018 via email

@MLogdberg
Copy link
Collaborator

Wow that was a new one, never seen that before...
Is it the same if you try a new Logic App? Any special restrictions that you have? Using power shell to deploy or VSTS?

@joeyeng
Copy link
Contributor Author

joeyeng commented Sep 4, 2018

This was a new LA (first time deploying it to this subscription and resource group at least). I don't know of any special restrictions (I wasn't the one who created the resource group).. anything I should look for in particular? Using VSTS to deploy.

The azureblob_1 api connection resource itself looks good. It has a connected status and it's in the expected region (same as the logic app).

@joeyeng
Copy link
Contributor Author

joeyeng commented Sep 5, 2018

@MLogdberg Looking at the workflow definition of the generated template I see the connection referred to as azureblob_1: @parameters('$connections')['azureblob_1']['connectionId'], but the parameters lists the name as azureblob-1. One uses underscore and one uses dash. This seems like a problem. Or is that okay?

@joeyeng
Copy link
Contributor Author

joeyeng commented Sep 5, 2018

Yep, that was the problem. I changed them to match and now my LA is fixed.

So the tool created a parameter for the connection name:

"azureblob-1_name": {
      "value": "azureblob-1"
    }

The question is why did the dash get converted to an underscore.

@joeyeng
Copy link
Contributor Author

joeyeng commented Sep 6, 2018

@MLogdberg I've got a fix. The problem happens when the connection parameter name is different than the "connectionName". Very confusing, but yea. PR coming soon.

@MLogdberg
Copy link
Collaborator

Sounds good!

@joeyeng
Copy link
Contributor Author

joeyeng commented Sep 6, 2018

PR #35

@joeyeng joeyeng closed this as completed Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants