-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not support CTRL-U in password mode #43
Comments
Wow, you really type passwords like that? :) It's true that we have to setup some special terminal modes to avoid echoing the password. That swallows some key combinations. I have found that to be a problem thus far, but I'll take patches from people it bothers who can find a way around it. |
Hi @gutenye , just to be sure I'm understanding correctly. Are you expecting HighLine to "delete" all the line and come back to "home", so it would return only "world", not "hello\u0015world" ? If so, I think we could try to do this. For most common purposes of the echo = false use cases, handling backspace correctly is enough. |
Yeah, I'm not sure how much it's HighLine's responsibility to emulate full terminal behavior. It seems weird to me that a simple HighLine call might erase my terminal screen. We are currently planning the next major version of HighLine. We will include a discussion of where to draw these lines in the plans we make for that release. |
Yes, that's what I wanted. |
Hi @gutenye, Most projects that I know just delete (deprecate) old issues. But it's not the case here in HighLine. We don't give up! 😄 The first release of "io/console" was 0.3 at October 16, 2011 (6,5 KB). But, not mature, and in a time that some of the releases were yanked. The first "usable" release that I have notice is 0.4.1 at February 04, 2013 (8,5 KB) AFTER the opening of this issue. You can see the whole release history at https://rubygems.org/gems/io-console/versions The good news is that we currently have an "io/console" more mature with more features we could rely on so we don't have to take all the responsibilities for the console inside HighLine's code. I've just merged a PR that solves handling "CTRL-C" by relying on "io/console" functionalities that were released with Ruby version 2.7.0 at December, 2019 (when this issue had 7 years old. Is there any GitHub badge for solving a 10 years old issue? 😄 Hey @JEG2 keep an eye on this? Perhaps we take a picture of an "anniversary cake" for the issue. |
It was easier to treat CTRL-U as we are treating backspace now than to rely on |
Fix #43 - Ctrl-U (erase line) handling
Type "helloCTRL-Uworld"
The text was updated successfully, but these errors were encountered: