Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune frontend state tree #262

Merged
merged 5 commits into from
Jan 7, 2017
Merged

Prune frontend state tree #262

merged 5 commits into from
Jan 7, 2017

Conversation

mertkahyaoglu
Copy link
Member

@mertkahyaoglu mertkahyaoglu commented Jan 6, 2017

Content of the PR;

  • After Expose documents on collection index #211, collections/collection/documents/ endpoint is deprecated and documents key is moved to collections/collection/path endpoint. With this API change, the front end is fetching a collection and its documents with a single call. This allows us to store the information from that call in a single object rather than storing collections and documents of currently visited collection separately.

Before;

before

After currentDocuments removed;

after

  • Secondly, the front end now follows another method of deleting files. Formerly, once a file was deleted, it was filtered out from the list state until another request was made for that list. Now once it is deleted, a new list request is made rather than relying on the state. This ensures that the front end state is the same as the back end's.

@mertkahyaoglu mertkahyaoglu merged commit 9fa9c6b into master Jan 7, 2017
@mertkahyaoglu mertkahyaoglu deleted the prune-state branch January 7, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant