Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for editing drafts via admin interface #367

Merged
merged 17 commits into from
Oct 17, 2017

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented May 7, 2017

Fixes #186

  • API Support for drafts at namespace /drafts/
    • update fixture site
    • update API to handle drafts namespace
    • add specs for drafts namespace
  • Initialize frontend
  • Update documentation

/cc @benbalter

@ashmaroli ashmaroli force-pushed the drafts-api branch 2 times, most recently from aa2fc9b to 360a584 Compare May 7, 2017 09:44
@ashmaroli ashmaroli force-pushed the drafts-api branch 2 times, most recently from b15e893 to bcbdf19 Compare May 8, 2017 05:41
@ashmaroli
Copy link
Member Author

ashmaroli commented May 12, 2017

Will push a commit for documentation after initial review..

else
params["splat"].first
end
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be further split and DRYed up as below:

    # Returns the path to the requested file's containing directory
    def directory_path
      sanitized_path File.join(content_dir, params["splat"].first)
    end

    def content_dir
      case namespace
      when "collections"
        collection.relative_directory
      when "data"
        DataFile.data_dir
      when "drafts"
        "_drafts"
      else
        ""
      end
    end

Whatsay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfdye
Copy link

sfdye commented Oct 14, 2017

Thanks! Hope to see this feature soon ❤️

@ashmaroli
Copy link
Member Author

@mertkahyaoglu Is this going to be merged before #421? If yes, I'll push a documentation commit..

@mertkahyaoglu
Copy link
Member

mertkahyaoglu commented Oct 17, 2017

@ashmaroli yeah, I'm gonna suspend it until this gets merged.

@mertkahyaoglu mertkahyaoglu merged commit 6c4da49 into jekyll:master Oct 17, 2017
@mertkahyaoglu
Copy link
Member

Great work @ashmaroli 👍

@ashmaroli
Copy link
Member Author

Thank You 😃 🎉

@ashmaroli ashmaroli deleted the drafts-api branch March 11, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit drafts
4 participants