-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editing drafts via admin interface #367
Conversation
aa2fc9b
to
360a584
Compare
b15e893
to
bcbdf19
Compare
Will push a commit for documentation after initial review.. |
else | ||
params["splat"].first | ||
end | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be further split and DRYed up as below:
# Returns the path to the requested file's containing directory
def directory_path
sanitized_path File.join(content_dir, params["splat"].first)
end
def content_dir
case namespace
when "collections"
collection.relative_directory
when "data"
DataFile.data_dir
when "drafts"
"_drafts"
else
""
end
end
Whatsay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks! Hope to see this feature soon ❤️ |
@mertkahyaoglu Is this going to be merged before #421? If yes, I'll push a documentation commit.. |
@ashmaroli yeah, I'm gonna suspend it until this gets merged. |
Great work @ashmaroli 👍 |
Thank You 😃 🎉 |
Fixes #186
/drafts/
drafts
namespacedrafts
namespace/cc @benbalter