Implement Ducks: Modular Redux #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ashmaroli
reviewed
Oct 17, 2017
spec/fixtures/site/_config.yml
Outdated
| @@ -1,7 +1,7 @@ | |||
| title: Your awesome title | |||
|
|
|||
| # Load the admin interface. | |||
| plugins: | |||
| gems: | |||
There was a problem hiding this comment.
CAUTION: This reverts a recent change..
There was a problem hiding this comment.
You're right. But it gives me Deprecation: The 'plugins' configuration option has been renamed to 'plugins_dir'. Please update your config file accordingly. error. How do I fix this?
There was a problem hiding this comment.
That's probably because your Gemfile.lock is still using an older version of Jekyll. Running bundle update will remove the warning.
On an unrelated side-note, once PR #322 gets merged, every other developer locked to an older version will thenceforth not see the warning..
There was a problem hiding this comment.
Yeah that was it. bundle update jekyll solved the issue. Thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our current redux setup, if we want to add a new reducer, we have to add
actionTypes,actionsandreducerinto separate files. This is a really tedious work. It makes more sense for these pieces to be bundled together in an isolated module.With this PR, I migrated current structure to ducks model which is a modular way of creating reducers.