Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Ducks: Modular Redux #421

Merged
merged 6 commits into from
Oct 17, 2017
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/fixtures/site/_config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
title: Your awesome title

# Load the admin interface.
plugins:
gems:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAUTION: This reverts a recent change..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. But it gives me Deprecation: The 'plugins' configuration option has been renamed to 'plugins_dir'. Please update your config file accordingly. error. How do I fix this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably because your Gemfile.lock is still using an older version of Jekyll. Running bundle update will remove the warning.

On an unrelated side-note, once PR #322 gets merged, every other developer locked to an older version will thenceforth not see the warning..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was it. bundle update jekyll solved the issue. Thank you 👍

- jekyll-admin

# Exclude these files from being processed.
Expand Down
170 changes: 0 additions & 170 deletions src/actions/collections.js

This file was deleted.

63 changes: 0 additions & 63 deletions src/actions/config.js

This file was deleted.

105 changes: 0 additions & 105 deletions src/actions/datafiles.js

This file was deleted.

Loading