-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust gemspec to allow use with Jekyll 4.0 #492
Conversation
@zocoi Couple of comments (FYI):
|
… supported, added rucop-performance required by parent gem
@ashmaroli Agree with the comment, I also updated node to 8 which the oldest LTS version. Since jekyll 4 introduces new Rubocop configs and this gem inherits from those cops. I updated the codebase to clear all the offenses. |
Just heard about this project and would love to see this change make it in so I can try jekyll-admin on my blog. 💜 |
@ashmaroli I think this is ready to go, right? |
Not quite. First, I shall merge |
Good 👍 @zocoi We can merge this after conflicts are resolved then. |
@zocoi I've thinned out the changes made in this branch to keep the PR focused to the primary intention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. Seems to be all good!
Thank you for your contribution @zocoi 😃 |
you're welcome, thanks for responding to this PR quickly :) |
Since jejyll 4 is released, bump up the requirement version