Add Explorer component to render resource indexes #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was planning to achieve the same. I have something bigger in mind though: rewriting whole frontend from scratch with new React API because looking at the code from 3 years ago, makes me feel bad a bit. Of course, it'll take some time to do that but this could be a good start. Also I wanted to let you know that I'm going to start doing it sooner or later so maybe it's a good idea not to make big investments in the current code. |
That's something nice to look forward to.. 👍 |
mertkahyaoglu
approved these changes
Nov 20, 2019
|
|
||
| render() { | ||
| const { items, type, newBtnLabel, search, params } = this.props; | ||
| const typeLabel = type === 'datafiles' ? 'data files' : type; |
There was a problem hiding this comment.
We could create a constant for this later to get type labels;
const TYPE_LABELS = {
"datafiles": "data files",
"pages": "pages",
..
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front end for routes
/pages,/draftsand/dataare virtually identical except for the resource data, yet each component implements the same logic leading to repeated code.We can extract all the repeated logic into a new React component, currently named
Explorer.Note: Currently not useful to refactoring the front end for posts and other documents.